Port bindings-doctests.sh into CI#5155
Queued
bfops wants to merge 3 commits into
Queued
Conversation
bfops
changed the title
bindings-doctests.sh into CI
bfops
commented
May 31, 2026
cloutiertyler
approved these changes
Jun 2, 2026
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
Looks good, but I don't see where this is actually adding these tests to CI.
Collaborator
Author
They're added here: https://github.com/clockworklabs/SpacetimeDB/pull/5155/changes#diff-8eeef336da059361b3b8f02cf2bae974d463bf491e998acef11397dd68038eb4R619-R622 |
jdetter
approved these changes
Jun 2, 2026
Contributor
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
Seems fine, not manually tested by me.
Contributor
|
Ahh sorry, I thought that was adding a new command, not adding it to an existing command. Apologies. |
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Part of #4970.
Doing this part in a separate PR because it turns out that this test was failing, so this PR also includes the fixes.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
CI passes (but only with the "code" changes).